Correctly handle a list of type geo in json (#2482) #2485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
manishrjain
suggested changes
Jul 16, 2018
There was a problem hiding this comment.
Can you add a TODO to consolidate the common logic to parse Geo into a function? Also, did you run tests to ensure that it doesn't affect anything else?
Reviewed 2 of 2 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
|
Sure, can add the function myself to parse the geo or add the TODO. Ran all tests, nothing broke. |
|
Updated branch with a handleGeoType function that is being called for the single geo object and list of geo objects. |
|
Thanks for your contribution! |
dna2github
pushed a commit
to dna2fork/dgraph
that referenced
this pull request
Jul 19, 2019
…io#2485) * Correctly handle list of type geo in json (dgraph-io#2482) * Add handleGeoType function for handling a geotype or list of geotype (dgraph-io#2482)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding a list of geo types in a json string, the geojson string was being parsed as a list of connecting entities. I've added a check for geojson in the handling of the []map[string]interface{} case.
Updated the list test to include a list of geojson.
This change is